Skip to content

Update to polkadot-sdk stable2412 #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manuelmauro merged 201 commits into from
May 13, 2025
Merged

Update to polkadot-sdk stable2412 #3224

manuelmauro merged 201 commits into from
May 13, 2025

Conversation

@manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Mar 20, 2025 •
edited by RomarQ
Loading

What does it do?

It updates polkadot-sdk to version stable2412.

⚠️ Breaking Changes ⚠️

  • Removes precompile StorageCleanerPrecompile.

Review Checklist

Important PRs

Tanssi's Experience Upgrading to Polkadot SDK 2412

Main PRs

Not Important But Good To Know

  • extension weights - terminology change: unsigned => bare. Also refactors traits such as CreateSignedTransaction
  • deprecate RuntimeString - Remove sp_runtime::RuntimeString and replace with Cow<'static, str> or String depending on se case
  • system_version - rename RuntimeVersion::state_version to system_version. Setting system_version = 2 will make xtrinsics use StateVersion::V1 instead of V0, but we don't do that, and neither does parity
  • remove ttl field - not removed, instead deprecated and ignored

New Types In Pallet Config

@manuelmauro
build: ⬆️ upgrade to Rust 1.82
06588f6
@manuelmauro
feat: ✨ update to polkadot-stable2412-2
7df3cd9
@manuelmauro
fix: 🐛 fix U256 conversions
613392c
@manuelmauro
fix: 🐛 fix deprecated runtime strings
3429b2d
@manuelmauro
fix: 🐛 fix occurrences of removed subs_of and super_of methods
7271df1
@manuelmauro
fix: 🐛 fix occurences of removed registrars and identity methods
000add4
@manuelmauro
fix: 🐛 dereference Arc smart pointer
53016a9
@manuelmauro
fix: 🐛 update deprecated state_version field
6089784
@manuelmauro
fix: 🐛 update renamed field require_weight_at_most
80de451
@manuelmauro
fix: 🐛 upgrade deprecated method new_unsigned calls to new_bare
3c4dbe2
@manuelmauro
fix: 🐛 upgrade use of deprecated get_from_seed function
2248317
@manuelmauro
fix: 🐛 correctly build Westend's network ID
ae4c1c9
@manuelmauro
fix: 🐛 use total_weight method instead of weight field
e04ff90
@manuelmauro
fix: 🐛 temporarily fix weight functions compilation errors
970bb83
@manuelmauro
fix: 🐛 fix runtime string convertion
d36c606
@manuelmauro
fix: 🐛 upgrade Runtime associated types
1f18ec3
@manuelmauro
fix: 🐛 temporarily fix more weight functions compilation errors
4f9bf12
@manuelmauro
fix: 🐛 remove StorageCleanerPrecompile
d64bd5f
@manuelmauro
fix: 🐛 set Consideration associated type to unit
e8d657b
@manuelmauro
fix: 🐛 automatically convert locations to the right XCM VersionedLoca…
bfef7a5 
…tion
@manuelmauro
fix: 🐛 migrate to xcm::v5::Location
c543b0a
@manuelmauro
fix: 🐛 automatically convert assets IDs to the right XCM VersionedAss…
281ffa4 
…etId
@manuelmauro
fix: 🐛 replace xcm::v4 with xcm::v5
47a5d82
@manuelmauro
fix: 🐛 fix pattern matching for versioned asset
1e6a2a1
@manuelmauro
fix: 🐛 replace VersionedXcm::<()>::V4 with VersionedXcm::<()>::V5
f881fed
@manuelmauro
fix: 🐛 automatically convert assets to the right XCM VersionedAssets
5042ce7
@manuelmauro
fix: 🐛 fix runtime string conversion
3eb37b0
@manuelmauro
fix: 🐛 fix XCM v3-v5 conversions
1a32b2b
@manuelmauro
fix: 🐛 correctly access UncheckedExtrinsic signature data
d1bc8d1
@manuelmauro
fix: 🐛 fix one more damned U256 conversion
e89d40c
@manuelmauro
Copy link
Contributor Author

manuelmauro commented May 9, 2025

We need to rename MM_MigrateToLatestXcmVersion to MM_MigrateToV5XcmVersion. Otherwise, the migration will not run.

Enabled in 5d44ae8

librelois
librelois reviewed May 12, 2025
View reviewed changes
librelois
librelois reviewed May 12, 2025
View reviewed changes
@RomarQ RomarQ mentioned this pull request May 12, 2025
Merged
@RomarQ RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label May 12, 2025
@RomarQ
Copy link
Contributor

RomarQ commented May 13, 2025 •
edited
Loading

We need to merge the changes from master

RomarQ
RomarQ reviewed May 13, 2025
View reviewed changes
stiiifff
stiiifff reviewed May 13, 2025
View reviewed changes
@manuelmauro
Copy link
Contributor Author

manuelmauro commented May 13, 2025

We need to merge the changes from master

Merged in c83782c

stiiifff
stiiifff approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@stiiifff stiiifff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@manuelmauro manuelmauro merged commit a84f80a into master May 13, 2025
37 checks passed
@manuelmauro manuelmauro deleted the update-polkadot-stable2412-rc2 branch May 13, 2025 16:20
@ibbar ibbar mentioned this pull request Jun 17, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@librelois librelois librelois left review comments

@stiiifff stiiifff stiiifff approved these changes

@RomarQ RomarQ RomarQ approved these changes

Assignees

@manuelmauro manuelmauro

Labels

A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manuelmauro @RomarQ @stiiifff @librelois